Update RenderUtils.java #450
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix client crash if biome doesnt have any type assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue which i ran into when using RandomThings (might be related to OpenTerrainGenerator or JustEnoughIDs)
I'm not sure if this is the best way to fix it as im not familiar with biome related stuff
The amount of changed lines is due to that i've moved some duplicated code to a separate function call, the main logic change is on the linked line, which checks if the biome has any type assigned before manipulating the biome color based on the biome type
Random-Things/src/main/java/lumien/randomthings/util/client/RenderUtils.java
Line 113 in 8235fa7
crash report of rendering a cable facade with biome stone in JEI
https://pastebin.com/raw/NiiSjdWx