Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SurveyJS locale #98

Merged
merged 8 commits into from
Nov 4, 2024
Merged

SurveyJS locale #98

merged 8 commits into from
Nov 4, 2024

Conversation

okaycj
Copy link
Collaborator

@okaycj okaycj commented Oct 31, 2024

Summary

Basically, set SurveyJS Localization parameter.

TODO

Update documentation for exit survey.

Copy link

changeset-bot bot commented Oct 31, 2024

🦋 Changeset detected

Latest commit: ffdbf3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lookit/surveys Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@okaycj okaycj changed the title Surveyjs locale SurveyJS locale Oct 31, 2024
@becky-gilbert becky-gilbert linked an issue Oct 31, 2024 that may be closed by this pull request
2 tasks
@becky-gilbert
Copy link
Contributor

FYI, I added the locale parameter to the survey docs: #102

@okaycj okaycj merged commit 0bcc29a into exit-survey-i18n Nov 4, 2024
2 checks passed
@okaycj okaycj deleted the surveyjs-locale branch November 4, 2024 15:37
okaycj added a commit that referenced this pull request Nov 4, 2024
* Remove unneeded survey-jquery package

* Set surveyJS locale

* Update plugin with new survey function

* Remove print statement

* Add tests for SurveyJS locale

* Changeset

* Add locale to consent survey

* Update tests
okaycj added a commit that referenced this pull request Nov 4, 2024
* Rename exit survey file

* Move exit json data to templates

* Replace exit survey's text with translation keys

* Incorporate node lts v22.x

* Update dependencies

* Add locale parameter and move survey text code to templates

* Remove unneeded file

* Update tests

* Add function to index

* These functions don't need to be exported

* Add conditional for choices element

* Update exit survey for tests and add tests

* Github actions doesn't support v22 just yet.

* Update to package lock

* Fix test issue were v18 doesn't like "Object.defineProperty"

* Changeset

* SurveyJS locale (#98)

* Remove unneeded survey-jquery package

* Set surveyJS locale

* Update plugin with new survey function

* Remove print statement

* Add tests for SurveyJS locale

* Changeset

* Add locale to consent survey

* Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add locale/translations for survey plugins
2 participants