Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iife only build #42

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Remove iife only build #42

merged 1 commit into from
Aug 22, 2024

Conversation

okaycj
Copy link
Collaborator

@okaycj okaycj commented Aug 21, 2024

Summary

I was running across an issue where packages couldn't reference another package. This was resolved by adding back in the CommonJS builds. Easy fix, embarrassing mistake.

Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: 8e0c636

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@okaycj okaycj changed the base branch from main to jspsych-8.0.2 August 21, 2024 19:22
@okaycj okaycj merged commit cf28a17 into jspsych-8.0.2 Aug 22, 2024
2 checks passed
@okaycj okaycj deleted the remove-iife-only-build branch August 22, 2024 18:49
okaycj added a commit that referenced this pull request Aug 27, 2024
* Move jspsych version to 8.0.2

* Format fix

* Fixed issue with cross package references (#42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants