Skip to content

Commit

Permalink
add record package to rollup external dependencies and globals, and s…
Browse files Browse the repository at this point in the history
…top exporting iife names from packages into root rollup config due to circular import / reference errors
  • Loading branch information
becky-gilbert committed Aug 2, 2024
1 parent 2681ffc commit 6dc0e3c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
4 changes: 1 addition & 3 deletions packages/data/rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ import { nodeResolve } from "@rollup/plugin-node-resolve";
import dotenv from "rollup-plugin-dotenv";
import { makeRollupConfig } from "../../rollup.mjs";

export const iifeNameData = "chsData";

export default makeRollupConfig(iifeNameData).map((config) => {
export default makeRollupConfig("chsData").map((config) => {
return {
...config,
plugins: [
Expand Down
10 changes: 7 additions & 3 deletions rollup.mjs
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
import { makeRollupConfig as jsPsychMakeRollupConfig } from "@jspsych/config/rollup";
import { iifeNameData } from "./packages/data/rollup.config.mjs";

export function makeRollupConfig(iifeName) {
const dataPackageName = "@lookit/data";
const dataPackageIifeName = "chsData"
const recordPackageName = "@lookit/record";
const recordPackageIifeName = "chsRecord";

return jsPsychMakeRollupConfig(iifeName).map((config) => {
return {
...config,
// Add data package as external dependency
external: [...config.external, dataPackageName],
external: [...config.external, dataPackageName, recordPackageName],
output: config.output
// Only build iife bundles
.filter((output) => output.format === "iife")
Expand All @@ -17,7 +20,8 @@ export function makeRollupConfig(iifeName) {
globals: {
...output.globals,
// Explicitly state data's iife name
[dataPackageName]: iifeNameData,
[dataPackageName]: dataPackageIifeName,
[recordPackageName]: recordPackageIifeName,
},
};
}),
Expand Down

0 comments on commit 6dc0e3c

Please sign in to comment.