Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user-defined literals for string_view #3

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Add user-defined literals for string_view #3

merged 4 commits into from
Feb 18, 2025

Conversation

loliGothicK
Copy link
Owner

@loliGothicK loliGothicK commented Feb 12, 2025

This pull request makes several enhancements and corrections to the unindent library. The key changes include:

  • README.md:
    • Updated the documentation to reflect the addition of new user-defined literals (_iv and _i1v).
    • Detailed the behavior of each new literal and provided examples.
    • Added a new section explaining the differences between _i and _iv (_i1 and _i1v) and how they interact with std::format.
    • Updated descriptions and examples to use basic_fixed_string instead of fixed_string.
  • include/unindent/unindent.hpp:
    • Renamed fixed_string to basic_fixed_string to better reflect its purpose as a structural type.
    • Added new user-defined literals (_iv and _i1v) and their corresponding implementations.
    • Introduced alias templates and deduction guides for basic_fixed_string.
  • tests/test.cpp:
    • Updated test cases to use basic_fixed_string instead of fixed_string.
    • Added new test cases for the _iv and _i1v user-defined literals to ensure correct behavior.

@loliGothicK loliGothicK force-pushed the fix/actions branch 2 times, most recently from 699158f to 1fde934 Compare February 12, 2025 22:32
@loliGothicK loliGothicK changed the title Fix/actions User-defined literals for string_view Feb 18, 2025
@loliGothicK loliGothicK self-assigned this Feb 18, 2025
@loliGothicK loliGothicK added the enhancement New feature or request label Feb 18, 2025
@loliGothicK loliGothicK changed the title User-defined literals for string_view Add user-defined literals for string_view Feb 18, 2025
@yukatayu
Copy link

読みましたが変な点は見当たらないです。
良さそう…!

@loliGothicK loliGothicK merged commit 579efe6 into main Feb 18, 2025
9 checks passed
@loliGothicK loliGothicK deleted the fix/actions branch February 19, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants