Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flang-aarch64-out-of-tree build flang-rt #388

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Meinersbur
Copy link
Member

@Meinersbur Meinersbur commented Feb 22, 2025

Make FlangBuilder.getFlangOutOfTreeBuildFactory build the flang-rt runtime as an out-of-tree runtimes build with additional steps.

Fixes some issues with FlangBuilder too:

  • Clears the build directories with the clean_obj flag set. Usually buildbot deletes the build directory whenever a CMakeLists.txt in a depends_on_projects subdirectory changes to get a clean build. Otherwise, an incompatiable CMakeCache.txt will carry on forever.
  • Add flang and flang-rt as depends_on_projects. Otherwise, changes in these subdirectories do not trigger a build. Even worse, breaking commits will be attributed to the next commit in llvm/clang/mlir/openmp, as happed in e.g. https://lab.llvm.org/buildbot/#/builders/53/builds/11759 (commit causing failure was llvm/llvm-project@fe8b323)

This PR is not necessary for llvm/llvm-project#124126, it just wouldn't build the runtime anymore.

Affected builders:

  • flang-aarch64-out-of-tree

Affected workers:

  • linaro-flang-aarch64-out-of-tree

Verfied locally on x86_64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant