-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the option to turn off ticks mirrored #15
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 76.15% 76.86% +0.71%
==========================================
Files 8 8
Lines 130 134 +4
==========================================
+ Hits 99 103 +4
Misses 31 31 ☔ View full report in Codecov by Sentry. |
@phyjswang will you have time to do the revisions? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to be merged.
Sorry. I am not aware of any new commit addressing the review I made above. |
Forgive me for not very familiar with GitHub PR stuffs. What is your review? I do not find it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better if these two options are explicitly listed as keyword args of theme_aps with default value true. Once you make this modification, I will merge the PR. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better if these two options are explicitly listed as keyword args of theme_aps
with default value true
. Once you make this modification, I will merge the PR. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've made the changes.
make xticksmirrored and yticksmirrored as keyword args of theme_aps with default value true
Dear Prof. Liu,
Thanks for this wonderful package!
For the APS theme,
theme.Axis.yticksmirrored
is alwaystrue
. But when using left and right y axis for different quantities, one must turn off this option. Hence I add the key word argumentxticksmirrored
andyticksmirrored
to make them optionallyfalse
.Best,
Junsen Wang