Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the option to turn off ticks mirrored #15

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

phyjswang
Copy link

@phyjswang phyjswang commented Aug 14, 2024

Dear Prof. Liu,

Thanks for this wonderful package!

For the APS theme, theme.Axis.yticksmirrored is always true. But when using left and right y axis for different quantities, one must turn off this option. Hence I add the key word argument xticksmirrored and yticksmirrored to make them optionally false.

Best,
Junsen Wang

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.86%. Comparing base (25d179f) to head (759fbb6).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   76.15%   76.86%   +0.71%     
==========================================
  Files           8        8              
  Lines         130      134       +4     
==========================================
+ Hits           99      103       +4     
  Misses         31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liuyxpp
Copy link
Owner

liuyxpp commented Aug 22, 2024

@phyjswang will you have time to do the revisions? Thanks!

Copy link
Author

@phyjswang phyjswang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged.

@liuyxpp
Copy link
Owner

liuyxpp commented Aug 22, 2024

Ready to be merged.

Sorry. I am not aware of any new commit addressing the review I made above.

@phyjswang
Copy link
Author

Ready to be merged.

Sorry. I am not aware of any new commit addressing the review I made above.

Forgive me for not very familiar with GitHub PR stuffs. What is your review? I do not find it.

Copy link
Owner

@liuyxpp liuyxpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if these two options are explicitly listed as keyword args of theme_aps with default value true. Once you make this modification, I will merge the PR. Thanks!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if these two options are explicitly listed as keyword args of theme_aps with default value true. Once you make this modification, I will merge the PR. Thanks!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've made the changes.

make xticksmirrored and yticksmirrored as keyword args of theme_aps with default value true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants