Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvme: enforce ns granularity on ns create #2722

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

igaw
Copy link
Collaborator

@igaw igaw commented Feb 25, 2025

When the device supports the namespace granularity feature, update the alignment requirements accordingly. Because this is likely to change the capacity of the namespace also issue a info what is going to happen.

Fixes: #2721

@igaw igaw force-pushed the create-ns-align branch 2 times, most recently from aba43b9 to 8e5b686 Compare February 25, 2025 08:51
@igaw
Copy link
Collaborator Author

igaw commented Feb 25, 2025

Only compile tested and don't have any device at hand for testing. If anyone else could give it a go, I would highly appreciate it. Thanks.

@maurizio-lombardi
Copy link
Contributor

@igaw
You probably want to change the documentation as well https://github.com/linux-nvme/nvme-cli/blob/master/Documentation/nvme-create-ns.txt#L100

I would replace this phrase:
"[..] in standard SI units (aligned on 1Mib boundaries,
unless the controller recommends a smaller value)."

with the following:

"[...] in standard SI units (aligned on 1Mib boundaries,
unless the controller recommends a different value)."

When the device supports the namespace granularity feature, update the
alignment requirements accordingly. Because this is likely to change the
capacity of the namespace also issue a info what is going to happen.

Signed-off-by: Daniel Wagner <wagi@kernel.org>
@maurizio-lombardi
Copy link
Contributor

Looks ok to me now

@igaw igaw merged commit 4851c9b into linux-nvme:master Feb 26, 2025
18 checks passed
@igaw igaw deleted the create-ns-align branch February 26, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The LBA Format specified is not supported(0x410a) when creating last namespace
2 participants