-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins/ocp: Added OCP 2.6 telemetry support #2692
plugins/ocp: Added OCP 2.6 telemetry support #2692
Conversation
There is a build error and also checkpatch complains about style issues.
|
b02b0be
to
bca0df8
Compare
You need to use
|
121752f
to
d1c150c
Compare
@igaw - I have fixed the issue. Please check |
d1c150c
to
a19525e
Compare
plugins/ocp/ocp-telemetry-decode.c
Outdated
@@ -126,6 +132,19 @@ void print_telemetry_fifo_event(__u8 class_type, | |||
|
|||
printf(" CSTS Reg Data : 0x%08x\n", | |||
le32_to_cpu(csts_reg_data)); | |||
} else if (id == OOB_COMMAND) { | |||
printf(" Cmd Op Code : 0x%02x\n", data[0]); | |||
__u16 status = *(__u16 *)(data + 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to use the same memcpy trick as above, this likely to work on platforms which enforce data alignment.
The rest looks good.
a19525e
to
097e703
Compare
I've just updated the cross build containers, thus there are a bunch of new bugs. I'm fixing them up right now. |
Updated the Telemetry Structure and Enum to support the OCP 2.6 spec Reviewed-by: Karthik Balan <karthik.b82@samsung.com> Reviewed-by: Arunpandian J <arun.j@samsung.com> Signed-off-by: Vigneshwaran Saravanan/Vigneshwaran Saravanan <s.vignesh@samsung.com>
097e703
to
77b2bd3
Compare
Thanks! |
Updated the Telemetry Structure and Enum to support the OCP 2.6 spec
Reviewed-by: Karthik Balan karthik.b82@samsung.com
Reviewed-by: Arunpandian J arun.j@samsung.com