nvme: add dispersed-ns-participating-nss-log command #2691
Conversation
|
The changes depended on the libnvme PR linux-nvme/libnvme#950 changes. |
|
does anyone actually implement this log? Linux doesn't support the feature, so even if a device does support it, I don't think you get consistent enumeration in Linux. |
I have been frequently told that this is the case; most of the major storage vendors (claim to) support it. Not that we've actually ever tested this, being as it is a quite contentious topic with Linux. |
|
Should we not added the log command for now as not supported the feature by Linux? |
|
I don't see a problem by adding this command. There are many features which the Linux implementation doesn't support but nvme-cli is showing the output from the target. |
ikegami-t
force-pushed
the
dns-psub-log
branch
from
9d9b454 to
b55d134
Compare
|
Just rebased and added a documentation and completions. |
ikegami-t
force-pushed
the
dns-psub-log
branch
3 times, most recently
from
fe56948 to
e606057
Compare
Since added the NVMe 2.1 log page. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Added the nvme-dispersed-ns-participating-nss-log.txt file. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Both bash and zsh completions updated for the command. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Also fixed get-reg and set-reg commands completions. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
|
Thanks! |
Since added the NVMe 2.1 log page.