Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Do not register separate RT region heartbeat metrics for follower #1561

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

sixpluszero
Copy link
Contributor

@sixpluszero sixpluszero commented Feb 27, 2025

[server] Do not register separate RT region heartbeat metrics for follower

Separate HB metrics should only be applied to leader, not for follower. This will reduce unnecessary metric count.

How was this PR tested?

New Unit Test.

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

Copy link
Contributor

@ZacAttack ZacAttack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@sixpluszero sixpluszero merged commit b36fd44 into linkedin:main Feb 28, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants