-
Notifications
You must be signed in to change notification settings - Fork 92
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[dvc] Fix metrics reporting issue for DVRT and add more metrics (#1548)
1. Fixed an issue where the metrics for DVRT were being registered, but they weren't being emitted. 2. Added more metrics for DVRT to cover more operations for better visibility. 3. Removed unnecessary integration test steps for DVRT to speed up CI.
- Loading branch information
Showing
13 changed files
with
595 additions
and
151 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
...t/src/main/java/com/linkedin/davinci/stats/AggVersionedDaVinciRecordTransformerStats.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| package com.linkedin.davinci.stats; | ||
|
|
||
| import com.linkedin.davinci.config.VeniceServerConfig; | ||
| import com.linkedin.venice.meta.ReadOnlyStoreRepository; | ||
| import io.tehuti.metrics.MetricsRepository; | ||
|
|
||
|
|
||
| /** | ||
| * The store level stats for {@link com.linkedin.davinci.client.DaVinciRecordTransformer} | ||
| */ | ||
| public class AggVersionedDaVinciRecordTransformerStats | ||
| extends AbstractVeniceAggVersionedStats<DaVinciRecordTransformerStats, DaVinciRecordTransformerStatsReporter> { | ||
| public AggVersionedDaVinciRecordTransformerStats( | ||
| MetricsRepository metricsRepository, | ||
| ReadOnlyStoreRepository metadataRepository, | ||
| VeniceServerConfig serverConfig) { | ||
| super( | ||
| metricsRepository, | ||
| metadataRepository, | ||
| DaVinciRecordTransformerStats::new, | ||
| DaVinciRecordTransformerStatsReporter::new, | ||
| serverConfig.isUnregisterMetricForDeletedStoreEnabled()); | ||
| } | ||
|
|
||
| public void recordPutLatency(String storeName, int version, double value, long timestamp) { | ||
| recordVersionedAndTotalStat(storeName, version, stat -> stat.recordPutLatency(value, timestamp)); | ||
| } | ||
|
|
||
| public void recordDeleteLatency(String storeName, int version, double value, long timestamp) { | ||
| recordVersionedAndTotalStat(storeName, version, stat -> stat.recordDeleteLatency(value, timestamp)); | ||
| } | ||
|
|
||
| public void recordOnRecoveryLatency(String storeName, int version, double value, long timestamp) { | ||
| recordVersionedAndTotalStat(storeName, version, stat -> stat.recordOnRecoveryLatency(value, timestamp)); | ||
| } | ||
|
|
||
| public void recordOnStartVersionIngestionLatency(String storeName, int version, double value, long timestamp) { | ||
| recordVersionedAndTotalStat( | ||
| storeName, | ||
| version, | ||
| stat -> stat.recordOnStartVersionIngestionLatency(value, timestamp)); | ||
| } | ||
|
|
||
| public void recordOnEndVersionIngestionLatency(String storeName, int version, double value, long timestamp) { | ||
| recordVersionedAndTotalStat(storeName, version, stat -> stat.recordOnEndVersionIngestionLatency(value, timestamp)); | ||
| } | ||
|
|
||
| public void recordPutError(String storeName, int version, long timestamp) { | ||
| recordVersionedAndTotalStat(storeName, version, stat -> stat.recordPutError(timestamp)); | ||
| } | ||
|
|
||
| public void recordDeleteError(String storeName, int version, long timestamp) { | ||
| recordVersionedAndTotalStat(storeName, version, stat -> stat.recordDeleteError(timestamp)); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.