Adds an option to control utf8Encoding of strings. #567
+458
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-ukumar
reviewed
Jan 27, 2025
| @@ -114,6 +115,11 @@ public static void main(String[] args) throws Exception { | |||
| .defaultsTo("false") | |||
| .describedAs("true/false"); | |||
|
|
|||
| OptionSpec<String> enableUtf8Encoding = parser.accepts("enableUtf8Encoding", "adds codegen of UTF8 type for strings.") | |||
There was a problem hiding this comment.
Please expand the option description
li-ukumar
reviewed
Jan 27, 2025
| if (options.has(enableUtf8Encoding)) { | ||
| String value = options.valueOf(enableUtf8Encoding); | ||
| handleUtf8Encoding = Boolean.TRUE.equals(Boolean.parseBoolean(value)); | ||
| handleUtf8EncodingInPutByIndex = handleUtf8Encoding; |
There was a problem hiding this comment.
This should only be allowed if methodRepresentation and stringRepresentation are charSeq
li-ukumar
reviewed
Jan 27, 2025
| @@ -0,0 +1,15 @@ | |||
| { | |||
| "type": "record", | |||
| "namespace": "noutf8encoding", | |||
li-ukumar
reviewed
Jan 27, 2025
| @@ -0,0 +1,23 @@ | |||
| { | |||
| "type": "record", | |||
| "namespace": "noutf8encoding", | |||
There was a problem hiding this comment.
namespace and directories don't match. Please update the location
li-ukumar
reviewed
Jan 28, 2025
| noutf8encoding.TestCollections instance = generator.randomSpecific(noutf8encoding.TestCollections.class, | ||
| RecordGenerationConfig.newConfig().withAvoidNulls(true)); | ||
|
|
||
| // fields should contain String values |
li-ukumar
reviewed
Jan 28, 2025
...der/tests/tests-allavro/src/test/java/com/linkedin/avroutil1/builder/SpecificRecordTest.java
Outdated
Show resolved
Hide resolved
li-ukumar
reviewed
Jan 28, 2025
| @@ -248,7 +248,9 @@ public static void main(String[] args) throws Exception { | |||
| if (options.has(enableUtf8Encoding)) { | |||
| String value = options.valueOf(enableUtf8Encoding); | |||
| handleUtf8Encoding = Boolean.TRUE.equals(Boolean.parseBoolean(value)); | |||
| handleUtf8EncodingInPutByIndex = handleUtf8Encoding; | |||
| if (methodStringRepresentation.equals(StringRepresentation.CharSeq) && stringRepresentation.equals(StringRepresentation.CharSeq)) { | |||
There was a problem hiding this comment.
This will not work for the user silently. Lets throw an illegalArgumentException and add this requirement in the option description above too.
…thodStringRepresentation and stringRepresentation to CharSequence.
li-ukumar
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default behavior is set to true for backwards compatibility.