Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lnd compile-time dependency to v0.19 #1422

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions .github/actions/setup-go/action.yml

This file was deleted.

131 changes: 80 additions & 51 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ env:
# go needs absolute directories, using the $HOME variable doesn't work here.
GOPATH: /home/runner/work/go

GO_VERSION: '1.22.12'
GO_VERSION: '1.23.6'

LITD_ITEST_BRANCH: 'master'
LITD_ITEST_BRANCH: 'lnd-19'

jobs:
#######################
Expand All @@ -32,10 +32,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup go environment
uses: ./.github/actions/setup-go
- name: Setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v5
with:
go-version: '${{ env.GO_VERSION }}'

- name: docker image cache
uses: jpribyl/action-docker-layer-caching@v0.1.1
Expand All @@ -49,10 +51,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup go environment
uses: ./.github/actions/setup-go
- name: Setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v5
with:
go-version: '${{ env.GO_VERSION }}'

- name: Generate RPC stubs and check REST annotations
run: make rpc-check
Expand All @@ -62,10 +66,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup go environment
uses: ./.github/actions/setup-go
- name: Setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v3
with:
go-version: '${{ env.GO_VERSION }}'

- name: Run go mod tidy
run: make mod-check
Expand All @@ -75,10 +81,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup go environment
uses: ./.github/actions/setup-go
- name: Setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v5
with:
go-version: '${{ env.GO_VERSION }}'

- name: Run test vector creation check
run: make test-vector-check
Expand All @@ -88,7 +96,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Run migration check
run: make migration-check
Expand All @@ -101,10 +109,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup go environment
uses: ./.github/actions/setup-go
- name: Setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v5
with:
go-version: '${{ env.GO_VERSION }}'

- name: compile code
run: go install -v ./...
Expand All @@ -120,10 +130,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: setup go environment
uses: ./.github/actions/setup-go
- name: Setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v5
with:
go-version: '${{ env.GO_VERSION }}'

- name: check default values in sample-tapd.conf file
run: make sample-conf-check
Expand All @@ -136,7 +148,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up QEMU
uses: docker/setup-qemu-action@v2
Expand All @@ -163,10 +175,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: setup go ${{ env.GO_VERSION }}
uses: ./.github/actions/setup-go
- name: Setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v5
with:
go-version: '${{ env.GO_VERSION }}'

- name: build release for all architectures
run: make release
Expand All @@ -179,12 +193,14 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Setup go environment
uses: ./.github/actions/setup-go
- name: Setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v5
with:
go-version: '${{ env.GO_VERSION }}'

- name: run lint
run: make lint
Expand All @@ -197,10 +213,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup go environment
uses: ./.github/actions/setup-go
- name: Setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v5
with:
go-version: '${{ env.GO_VERSION }}'

- name: run format
run: make fmt
Expand All @@ -221,21 +239,24 @@ jobs:
- unit dbbackend=postgres
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup go environment
uses: ./.github/actions/setup-go
- name: Setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v5
with:
go-version: '${{ env.GO_VERSION }}'

- name: run ${{ matrix.unit_type }}
run: make ${{ matrix.unit_type }}

- name: Send coverage
uses: shogo82148/actions-goveralls@v1
uses: coverallsapp/github-action@v2
if: matrix.unit_type == 'unit-cover'
continue-on-error: true
with:
path-to-profile: coverage.txt
file: coverage.txt
flag-name: 'unit'
format: 'golang'
parallel: true

########################
Expand All @@ -246,10 +267,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup go environment
uses: ./.github/actions/setup-go
- name: Setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v5
with:
go-version: '${{ env.GO_VERSION }}'

- name: run itest
run: make itest cover=1
Expand All @@ -267,12 +290,13 @@ jobs:
retention-days: 5

- name: Send coverage
uses: shogo82148/actions-goveralls@v1
uses: coverallsapp/github-action@v2
if: ${{ success() }}
continue-on-error: true
with:
path-to-profile: itest/coverage.txt
file: itest/coverage.txt
flag-name: 'itest'
format: 'golang'
parallel: true

########################
Expand All @@ -283,10 +307,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup go environment
uses: ./.github/actions/setup-go
- name: Setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v5
with:
go-version: '${{ env.GO_VERSION }}'

- name: run itest
run: make itest dbbackend=postgres cover=1
Expand All @@ -304,12 +330,13 @@ jobs:
retention-days: 5

- name: Send coverage
uses: shogo82148/actions-goveralls@v1
uses: coverallsapp/github-action@v2
if: ${{ success() }}
continue-on-error: true
with:
path-to-profile: itest/coverage.txt
file: itest/coverage.txt
flag-name: 'itest'
format: 'golang'
parallel: true

########################
Expand All @@ -321,13 +348,15 @@ jobs:

steps:
- name: git checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup go environment
uses: ./.github/actions/setup-go
- name: Setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v5
with:
go-version: '${{ env.GO_VERSION }}'

- name: Clone Lit repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: lightninglabs/lightning-terminal
ref: ${{ env.LITD_ITEST_BRANCH }}
Expand Down Expand Up @@ -365,7 +394,7 @@ jobs:
needs: [unit-test]
runs-on: ubuntu-latest
steps:
- uses: shogo82148/actions-goveralls@v1
- uses: coverallsapp/github-action@v2
continue-on-error: true
with:
parallel-finished: true
6 changes: 3 additions & 3 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ defaults:
shell: bash

env:
GO_VERSION: 1.22.12
GO_VERSION: 1.23.6

jobs:
main:
name: Release build
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 0

Expand All @@ -38,7 +38,7 @@ jobs:
fi

- name: setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v2
uses: actions/setup-go@v5
with:
go-version: '${{ env.GO_VERSION }}'

Expand Down
2 changes: 2 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ linters-settings:
excludes:
- G402 # Look for bad TLS connection settings.
- G306 # Poor file permissions used when writing to a new file.
- G601 # Implicit memory aliasing in for loop.
- G115 # Integer overflow conversion.
exhaustive:
default-signifies-exhaustive: true
gocritic:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.12-alpine as builder
FROM golang:1.23.6-alpine as builder

# Force Go to use the cgo based DNS resolver. This is required to ensure DNS
# queries required to connect to linked containers succeed.
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ DOCKER_TOOLS = docker run \
-v $(shell bash -c "mkdir -p /tmp/go-lint-cache; echo /tmp/go-lint-cache"):/root/.cache/golangci-lint \
-v $$(pwd):/build taproot-assets-tools

GO_VERSION = 1.22.12
GO_VERSION = 1.23.6

GREEN := "\\033[0;32m"
NC := "\\033[0m"
Expand Down
2 changes: 1 addition & 1 deletion address/log.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package address

import (
"github.com/btcsuite/btclog"
"github.com/btcsuite/btclog/v2"
)

// Subsystem defines the logging code for this subsystem.
Expand Down
Loading
Loading