Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple improvements #43

Merged
merged 4 commits into from
Jun 19, 2024
Merged

multiple improvements #43

merged 4 commits into from
Jun 19, 2024

Conversation

Sledro
Copy link
Member

@Sledro Sledro commented Jun 6, 2024 •
edited
Loading

  • adds missing new config vars to the example config .env file
  • logs the address of the private key ETH_KEY env var on startup
  • fixes Ethereum.Wait() function by waiting for tx receipts
  • automatically claims DA & L2 Header challenge rewards after defending (useful as we can run constant challenge bot to test and don't have to claim eth back for hundreds of challenges manually)

CleanShot 2024-06-06 at 22 19 38@2x

CleanShot 2024-06-06 at 22 20 02@2x

CryptoKass
CryptoKass approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@CryptoKass CryptoKass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Ethereum.Wait() should probably be moved from canonical_state_chain.go to ethereum.go.

This looks good 👍

@Sledro Sledro merged commit 6dbb103 into main Jun 19, 2024
2 checks passed
@Sledro Sledro deleted the feature/multiple-improvements branch June 19, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CryptoKass CryptoKass CryptoKass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sledro @CryptoKass