-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: adds private docker container support #179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0rthak
reviewed
Jan 22, 2025
s0rthak
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
danielboloc
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for "Use private Docker repository" feature in CloudOS.

This new feature allows the user to run using private docker images from their personal docker.io account.
The users have to link their docker.io account to cloudOS using the UI. If docker.io account is not linked, the user won't see the "Use private Docker repository" option in batch queue options. They will see a link to the page for connecting accounts.

This feature doesn't work with system-tools and similar (Module workflows), as there is no option to select queues and then the option for use private Docker repo is not shown.
Jira
https://lifebit.atlassian.net/browse/LIF-1568
Changes
--use-private-docker-repository
added tocloudos job run
command.cloudos jog run --use-private-docker-repository
:Cloudos.get_user_info
has been added to be able to inspect user's credentials.Tests
Using docker image:
Global variables:
Sending a job with default params (not using the new flag)
Sending a job using
--use-private-docker-repository
from a user that has the credentials linkedNote
The queue used is now a clone from the previous one
Sending a job using
--use-private-docker-repository
from a user that doesn't have the credentials linkedSending a GWAS job (a module tool) using
--use-private-docker-repository
from a user that has the credentials linkedNote
It is using the expected system-tools queue