[WIP] CLI #1
Merged
[WIP] CLI #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiRaiks
reviewed
Jan 31, 2025
| @@ -1,2 +1,21 @@ | |||
| import { Command } from "commander"; | |||
| export const program = new Command(); | |||
| // import { setAdvancedConfig } from "@features"; | |||
DiRaiks
reviewed
Jan 31, 2025
| export * from "./Delegation"; | ||
| export * from "./StEth"; | ||
| export * from "./LidoLocator"; | ||
| export * from "./TokenManager"; |
There was a problem hiding this comment.
Why do we need this contract?
DiRaiks
reviewed
Jan 31, 2025
| export const voteLastVoting = async () => { | ||
| const { contract } = getVotingContract(); | ||
| const votesLength = await contract.read.votesLength(); | ||
| const lastVoteId = votesLength - 1n; |
There was a problem hiding this comment.
Why do we use only the last vote?
DiRaiks
reviewed
Jan 31, 2025
| }, {} as Record<string, any>); | ||
| } | ||
|
|
||
| // export const checkTmCanForward = async () => { |
DiRaiks
reviewed
Jan 31, 2025
| const dashboard = program.command("dashboard").description("dashboard contract"); | ||
|
|
||
| dashboard | ||
| .command("info") |
There was a problem hiding this comment.
Not blocker:
Looks like we need separate files for different commands by type
DiRaiks
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Demo
Code review notes
Testing notes
Checklist: