Merge pull request #111 from lidofinance/fix/operation-id

fix: non-random operation ID

client/client.go

@@ -16,7 +16,6 @@ import (
 
 	sipf "github.com/lidofinance/dc4bc/fsm/state_machines/signing_proposal_fsm"
 
-	"github.com/google/uuid"
 	"github.com/lidofinance/dc4bc/client/types"
 	"github.com/lidofinance/dc4bc/fsm/types/requests"
 
@@ -312,18 +311,16 @@ func (c *BaseClient) ProcessMessage(message storage.Message) error {
 				}
 			}
 
-			bz, err := json.Marshal(resp.Data)
+			operationPayloadBz, err := json.Marshal(resp.Data)
 			if err != nil {
 				return fmt.Errorf("failed to marshal FSM response: %w", err)
 			}
 
-			operation = &types.Operation{
-				ID:            uuid.New().String(),
-				Type:          types.OperationType(resp.State),
-				Payload:       bz,
-				DKGIdentifier: message.DkgRoundID,
-				CreatedAt:     time.Now(),
-			}
+			operation = types.NewOperation(
+				message.DkgRoundID,
+				operationPayloadBz,
+				resp.State,
+			)
 		}
 	default:
 		c.Logger.Log("State %s does not require an operation", resp.State)

client/types/types.go

@@ -2,6 +2,8 @@ package types
 
 import (
 	"bytes"
+	"crypto/md5"
+	"encoding/base64"
 	"encoding/json"
 	"fmt"
 	"time"
@@ -43,6 +45,26 @@ type Operation struct {
 	Event         fsm.Event
 }
 
+func NewOperation(
+	dkgRoundID string,
+	payload []byte,
+	state fsm.State,
+) *Operation {
+	operationID := fmt.Sprintf(
+		"%s_%s",
+		dkgRoundID,
+		base64.StdEncoding.EncodeToString(payload),
+	)
+	operationIDmd5 := md5.Sum([]byte(operationID))
+	return &Operation{
+		ID:            string(operationIDmd5[:]),
+		Type:          OperationType(state),
+		Payload:       payload,
+		DKGIdentifier: dkgRoundID,
+		CreatedAt:     time.Now(),
+	}
+}
+
 func (o *Operation) Check(o2 *Operation) error {
 	if o.ID != o2.ID {
 		return fmt.Errorf("o1.ID (%s) != o2.ID (%s)", o.ID, o2.ID)

cmd/dc4bc_cli/main.go

@@ -690,7 +690,7 @@ func getFSMStatusCommand() *cobra.Command {
 				fmt.Printf("Waiting for data from: %s\n", strings.Join(waiting, ", "))
 			}
 			if len(confirmed) > 0 {
-				fmt.Printf("Received a data from: %s\n", strings.Join(confirmed, ", "))
+				fmt.Printf("Received data from: %s\n", strings.Join(confirmed, ", "))
 			}
 			if len(failed) > 0 {
 				fmt.Printf("Participants who got some error during a process: %s\n", strings.Join(waiting, ", "))