-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vaults validators triggerable exits #933
Merged
Merged
+4,225
−623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add role ADD_FULL_WITHDRAWAL_REQUEST_ROLE for full withdrawal requests.
…hdrawal-credentials
Access pubkeys and amounts directly instead of copying them to memory.
pass pubkeys as array of bytes
…o feat/waults-triggerable-exits # Conflicts: # scripts/scratch/steps/0120-initialize-non-aragon-contracts.ts
# Conflicts: # contracts/0.8.25/vaults/Dashboard.sol # test/integration/vaults-happy-path.integration.ts
…le-exits # Conflicts: # contracts/0.8.9/WithdrawalVault.sol # contracts/common/lib/TriggerableWithdrawals.sol
…le-exits # Conflicts: # contracts/common/lib/TriggerableWithdrawals.sol # test/common/lib/triggerableWithdrawals/triggerableWithdrawals.test.ts
216c633
to
1f76bae
Compare
TheDZhon
reviewed
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 👏
# Conflicts: # contracts/0.8.25/vaults/Dashboard.sol # contracts/0.8.25/vaults/Permissions.sol # contracts/0.8.25/vaults/VaultFactory.sol # test/0.8.25/vaults/delegation/delegation.test.ts # test/0.8.25/vaults/staking-vault/stakingVault.test.ts # test/0.8.25/vaults/vaultFactory.test.ts # test/integration/vaults-happy-path.integration.ts
Co-authored-by: Eugene Mamin <TheDZhon@gmail.com>
feat: healthy ratio
# Conflicts: # package.json # scripts/scratch/steps/0120-initialize-non-aragon-contracts.ts
TheDZhon
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except only for:
- some naming discrepancy is still left
- a few items for backlog should be added (marked with the
⚠️ signs) - minor comment improvements
Co-authored-by: Eugene Mamin <TheDZhon@gmail.com>
This was referenced Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last changes:
requestValidatorExit
– just an event fromREQUEST_VALIDATOR_EXIT_ROLE
to NO to exit validators.triggerValidatorWithdrawal
- EIP-7002-based trigger for validators exit by VO of NO. Will trigger complete validators exit or partial withdrawals from the beacon chain.forceValidatorWithdrawal
– EIP-7002-based trigger for validators to exit that can be done via VaultHub to rebalance unbalanced vault back to balanced state, time-locked to allow the owner to rebalance without exiting the validators from the beacon chainExtras:
isBalanced
was removed from the StakingVault to avoid confusion.