Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vaults validators triggerable exits #933

Merged
merged 104 commits into from
Feb 26, 2025

Conversation

tamtamchik
Copy link
Member

@tamtamchik tamtamchik commented Jan 29, 2025

Last changes:

  • Limits moved to immutables
  • Removed MAX_PUBLIC_KEYS_PER_REQUEST
  • Renamed isDisconnected ⇒ pendingDisconnect
  • Added both indexed and not indexed keys to events
  • Updated vault health calculations

  • requestValidatorExit – just an event from REQUEST_VALIDATOR_EXIT_ROLE to NO to exit validators.
  • triggerValidatorWithdrawal - EIP-7002-based trigger for validators exit by VO of NO. Will trigger complete validators exit or partial withdrawals from the beacon chain.
  • forceValidatorWithdrawal – EIP-7002-based trigger for validators to exit that can be done via VaultHub to rebalance unbalanced vault back to balanced state, time-locked to allow the owner to rebalance without exiting the validators from the beacon chain

Extras:

  • Vault withdrawal credentials are set to 0x02 type.
  • isBalanced was removed from the StakingVault to avoid confusion.

mkurayan and others added 30 commits December 19, 2024 19:45
Add role ADD_FULL_WITHDRAWAL_REQUEST_ROLE for full withdrawal requests.
Access pubkeys and amounts directly instead of copying them to memory.
pass pubkeys as array of bytes
…o feat/waults-triggerable-exits

# Conflicts:
#	scripts/scratch/steps/0120-initialize-non-aragon-contracts.ts
# Conflicts:
#	contracts/0.8.25/vaults/Dashboard.sol
#	test/integration/vaults-happy-path.integration.ts
…le-exits

# Conflicts:
#	contracts/0.8.9/WithdrawalVault.sol
#	contracts/common/lib/TriggerableWithdrawals.sol
…le-exits

# Conflicts:
#	contracts/common/lib/TriggerableWithdrawals.sol
#	test/common/lib/triggerableWithdrawals/triggerableWithdrawals.test.ts
@tamtamchik tamtamchik force-pushed the feat/vaults-triggerable-exits branch from 216c633 to 1f76bae Compare February 18, 2025 14:23
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 👏

tamtamchik and others added 19 commits February 19, 2025 14:20
# Conflicts:
#	contracts/0.8.25/vaults/Dashboard.sol
#	contracts/0.8.25/vaults/Permissions.sol
#	contracts/0.8.25/vaults/VaultFactory.sol
#	test/0.8.25/vaults/delegation/delegation.test.ts
#	test/0.8.25/vaults/staking-vault/stakingVault.test.ts
#	test/0.8.25/vaults/vaultFactory.test.ts
#	test/integration/vaults-happy-path.integration.ts
Co-authored-by: Eugene Mamin <TheDZhon@gmail.com>
# Conflicts:
#	package.json
#	scripts/scratch/steps/0120-initialize-non-aragon-contracts.ts
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except only for:

  • some naming discrepancy is still left
  • a few items for backlog should be added (marked with the ⚠️ signs)
  • minor comment improvements

@tamtamchik tamtamchik merged commit 2dc2281 into feat/vaults Feb 26, 2025
9 checks passed
@tamtamchik tamtamchik deleted the feat/vaults-triggerable-exits branch February 26, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants