fix(Sideloading): update after vaulthub separation

lidofinance · Feb 28, 2025 · 7b95844 · 7b95844
1 parent 3f1622a
commit 7b95844
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/contracts/0.8.25/vaults/Sideloading.sol b/contracts/0.8.25/vaults/Sideloading.sol
@@ -55,17 +55,12 @@ contract Sideloading is VaultHub {
      * @notice Constructor.
      * @param _stETH The address of the STETH contract.
      */
-    constructor(IStETH _stETH) VaultHub(_stETH) {}
-
-    /**
-     * @notice Initializes the contract.
-     * @param _admin The address of the admin.
-     */
-    function initialize(address _admin) external initializer {
-        if (_admin == address(0)) revert ZeroArgument("_admin");
-
-        __VaultHub_init(_admin);
-    }
+    constructor(
+        IStETH _stETH,
+        address _accounting,
+        uint256 _connectedVaultsLimit,
+        uint256 _relativeShareLimitBP
+    ) VaultHub(_stETH, _accounting, _connectedVaultsLimit, _relativeShareLimitBP) {}
 
     /**
      * @notice Returns true if the sideloader registry is ignored and any address can be used as a sideloader.

diff --git a/test/0.8.25/vaults/sideloading/contracts/StETH__MockForSideloading.sol b/test/0.8.25/vaults/sideloading/contracts/StETH__MockForSideloading.sol
@@ -43,6 +43,10 @@ contract StETH__MockForSideloading is ERC20 {
         return shares;
     }
 
+    function getPooledEthBySharesRoundUp(uint256 shares) external view returns (uint256) {
+        return shares;
+    }
+
     // for simplicity, 1 steth = 1 share
     function getSharesByPooledEth(uint256 pooledEth) external view returns (uint256) {
         return pooledEth;

diff --git a/test/0.8.25/vaults/sideloading/sideloading.test.ts b/test/0.8.25/vaults/sideloading/sideloading.test.ts
@@ -46,7 +46,8 @@ describe("Sideloading.sol", () => {
     await setBalance(await swapper.getAddress(), ether("1000"));
     adapter = await ethers.deployContract("SwapperAdapter__MockForSideloading", [steth, swapper]);
 
-    const sideloadingImpl = await ethers.deployContract("Sideloading", [steth]);
+    const accounting = certainAddress("accounting");
+    const sideloadingImpl = await ethers.deployContract("Sideloading", [steth, accounting, 100n, 1000n]);
     [sideloading] = await proxify({ impl: sideloadingImpl, admin });
 
     await expect(sideloading.initialize(admin))