Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved factories to tests #512

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libp2p/tools/pubsub/dummy_account_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
Service,
background_trio_service,
)
from libp2p.tools.factories import (
from tests.factories import (
PubsubFactory,
)

Expand Down
1 change: 1 addition & 0 deletions tests/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Empty file to make the tests directory a Python package
2 changes: 1 addition & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import pytest

from libp2p.tools.factories import (
from tests.factories import (
HostFactory,
)

Expand Down
6 changes: 3 additions & 3 deletions tests/core/examples/test_examples.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@
from libp2p.peer.peerinfo import (
info_from_p2p_addr,
)
from libp2p.tools.factories import (
HostFactory,
)
from libp2p.tools.utils import (
MAX_READ_LEN,
)
from tests.factories import (
HostFactory,
)

PROTOCOL_ID = "/chat/1.0.0"

Expand Down
2 changes: 1 addition & 1 deletion tests/core/host/test_connected_peers.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from libp2p.peer.peerinfo import (
info_from_p2p_addr,
)
from libp2p.tools.factories import (
from tests.factories import (
HostFactory,
)

Expand Down
2 changes: 1 addition & 1 deletion tests/core/host/test_ping.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
PING_LENGTH,
PingService,
)
from libp2p.tools.factories import (
from tests.factories import (
host_pair_factory,
)

Expand Down
2 changes: 1 addition & 1 deletion tests/core/host/test_routed_host.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from libp2p.peer.peerinfo import (
PeerInfo,
)
from libp2p.tools.factories import (
from tests.factories import (
HostFactory,
RoutedHostFactory,
)
Expand Down
2 changes: 1 addition & 1 deletion tests/core/identity/identify/test_protocol.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
ID,
_mk_identify_protobuf,
)
from libp2p.tools.factories import (
from tests.factories import (
host_pair_factory,
)

Expand Down
2 changes: 1 addition & 1 deletion tests/core/network/conftest.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import pytest

from libp2p.tools.factories import (
from tests.factories import (
net_stream_pair_factory,
swarm_conn_pair_factory,
swarm_pair_factory,
Expand Down
6 changes: 3 additions & 3 deletions tests/core/network/test_notify.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@
from libp2p.tools.constants import (
LISTEN_MADDR,
)
from libp2p.tools.factories import (
SwarmFactory,
)
from libp2p.tools.utils import (
connect_swarm,
)
from tests.factories import (
SwarmFactory,
)


class Event(enum.Enum):
Expand Down
6 changes: 3 additions & 3 deletions tests/core/network/test_swarm.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
from libp2p.network.exceptions import (
SwarmException,
)
from libp2p.tools.factories import (
SwarmFactory,
)
from libp2p.tools.utils import (
connect_swarm,
)
from tests.factories import (
SwarmFactory,
)


@pytest.mark.trio
Expand Down
6 changes: 3 additions & 3 deletions tests/core/protocol_muxer/test_protocol_muxer.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
from libp2p.host.exceptions import (
StreamFailure,
)
from libp2p.tools.factories import (
HostFactory,
)
from libp2p.tools.utils import (
create_echo_stream_handler,
)
from tests.factories import (
HostFactory,
)

PROTOCOL_ECHO = "/echo/1.0.0"
PROTOCOL_POTATO = "/potato/1.0.0"
Expand Down
6 changes: 3 additions & 3 deletions tests/core/pubsub/test_floodsub.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@
from libp2p.peer.id import (
ID,
)
from libp2p.tools.factories import (
PubsubFactory,
)
from libp2p.tools.pubsub.floodsub_integration_test_settings import (
floodsub_protocol_pytest_params,
perform_test_from_obj,
)
from libp2p.tools.utils import (
connect,
)
from tests.factories import (
PubsubFactory,
)


@pytest.mark.trio
Expand Down
8 changes: 4 additions & 4 deletions tests/core/pubsub/test_gossipsub.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@
from libp2p.pubsub.gossipsub import (
PROTOCOL_ID,
)
from libp2p.tools.factories import (
IDFactory,
PubsubFactory,
)
from libp2p.tools.pubsub.utils import (
dense_connect,
one_to_all_connect,
)
from libp2p.tools.utils import (
connect,
)
from tests.factories import (
IDFactory,
PubsubFactory,
)


@pytest.mark.trio
Expand Down
6 changes: 3 additions & 3 deletions tests/core/pubsub/test_gossipsub_backward_compatibility.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
from libp2p.tools.constants import (
FLOODSUB_PROTOCOL_ID,
)
from libp2p.tools.factories import (
PubsubFactory,
)
from libp2p.tools.pubsub.floodsub_integration_test_settings import (
floodsub_protocol_pytest_params,
perform_test_from_obj,
)
from tests.factories import (
PubsubFactory,
)


@pytest.mark.parametrize("test_case_obj", floodsub_protocol_pytest_params)
Expand Down
10 changes: 5 additions & 5 deletions tests/core/pubsub/test_pubsub.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@
from libp2p.tools.constants import (
MAX_READ_LEN,
)
from libp2p.tools.factories import (
IDFactory,
PubsubFactory,
net_stream_pair_factory,
)
from libp2p.tools.pubsub.utils import (
make_pubsub_msg,
)
Expand All @@ -35,6 +30,11 @@
from libp2p.utils import (
encode_varint_prefixed,
)
from tests.factories import (
IDFactory,
PubsubFactory,
net_stream_pair_factory,
)

TESTING_TOPIC = "TEST_SUBSCRIBE"
TESTING_DATA = b"data"
Expand Down
2 changes: 1 addition & 1 deletion tests/core/security/noise/test_msg_read_writer.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
MAX_NOISE_MESSAGE_LEN,
NoisePacketReadWriter,
)
from libp2p.tools.factories import (
from tests.factories import (
raw_conn_factory,
)

Expand Down
2 changes: 1 addition & 1 deletion tests/core/security/noise/test_noise.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from libp2p.security.noise.messages import (
NoiseHandshakePayload,
)
from libp2p.tools.factories import (
from tests.factories import (
noise_conn_factory,
noise_handshake_payload_factory,
)
Expand Down
2 changes: 1 addition & 1 deletion tests/core/security/test_secio.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from libp2p.tools.constants import (
MAX_READ_LEN,
)
from libp2p.tools.factories import (
from tests.factories import (
raw_conn_factory,
)

Expand Down
2 changes: 1 addition & 1 deletion tests/core/security/test_security_multistream.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from libp2p.security.secure_session import (
SecureSession,
)
from libp2p.tools.factories import (
from tests.factories import (
host_pair_factory,
)

Expand Down
2 changes: 1 addition & 1 deletion tests/core/stream_muxer/conftest.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import pytest

from libp2p.tools.factories import (
from tests.factories import (
mplex_conn_pair_factory,
mplex_stream_pair_factory,
)
Expand Down
6 changes: 3 additions & 3 deletions tests/core/test_libp2p/test_libp2p.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
from libp2p.tools.constants import (
MAX_READ_LEN,
)
from libp2p.tools.factories import (
HostFactory,
)
from libp2p.tools.utils import (
connect,
create_echo_stream_handler,
)
from tests.factories import (
HostFactory,
)

PROTOCOL_ID_0 = TProtocol("/echo/0")
PROTOCOL_ID_1 = TProtocol("/echo/1")
Expand Down
17 changes: 7 additions & 10 deletions libp2p/tools/factories.py → tests/factories.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,14 @@
background_trio_service,
)
from libp2p.tools.constants import (
FLOODSUB_PROTOCOL_ID,
GOSSIPSUB_PARAMS,
GOSSIPSUB_PROTOCOL_ID,
LISTEN_MADDR,
)
from libp2p.tools.utils import (
connect,
connect_swarm,
)
from libp2p.transport.tcp.tcp import (
TCP,
Expand All @@ -125,16 +132,6 @@
TransportUpgrader,
)

from .constants import (
FLOODSUB_PROTOCOL_ID,
GOSSIPSUB_PROTOCOL_ID,
LISTEN_MADDR,
)
from .utils import (
connect,
connect_swarm,
)

DEFAULT_SECURITY_PROTOCOL_ID = PLAINTEXT_PROTOCOL_ID


Expand Down
2 changes: 1 addition & 1 deletion tests/interop/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
)
from libp2p.security.noise.transport import PROTOCOL_ID as NOISE_PROTOCOL_ID
from libp2p.security.secio.transport import ID as SECIO_PROTOCOL_ID
from libp2p.tools.factories import (
from tests.factories import (
HostFactory,
PubsubFactory,
)
Expand Down
2 changes: 1 addition & 1 deletion tests/interop/test_bindings.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pytest
import trio

from libp2p.tools.factories import (
from tests.factories import (
HostFactory,
)
from tests.utils.interop.utils import (
Expand Down
Loading