Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add readme #533

Merged
merged 10 commits into from
Mar 13, 2024
Merged

feat: add readme #533

merged 10 commits into from
Mar 13, 2024

Conversation

ayushtom
Copy link
Contributor

@ayushtom ayushtom commented Mar 13, 2024

This PR adds a Readme and contribution guidelines to the repo which can help contributors to learn more about the project before starting to contribute

Note - i also add a package-lock.json file here because a lot of installation issues come up with different package managers (pnpm, bun ) used by contributors.

@ayushtom ayushtom marked this pull request as draft March 13, 2024 11:37
Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goerli-starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 5:44pm
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 5:44pm

Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording changes and questions !

@fricoben fricoben added ❌ Change request Change requested from reviewer and removed 🔥 Ready for review This pull request needs a review labels Mar 13, 2024
@ayushtom ayushtom removed the ❌ Change request Change requested from reviewer label Mar 13, 2024
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so you can merge after this last comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants