Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disable reward button when already claimed #499

Merged
merged 4 commits into from
Feb 5, 2024
Merged

feat: disable reward button when already claimed #499

merged 4 commits into from
Feb 5, 2024

Conversation

Marchand-Nicolas
Copy link
Collaborator

close: #478

@Marchand-Nicolas Marchand-Nicolas added the 🚧 In progress do not merge Pull Request in progress, please do not merge label Feb 3, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goerli-starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2024 0:05am
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2024 0:05am

@Marchand-Nicolas Marchand-Nicolas added 🔥 Ready for review This pull request needs a review 🦾 Needs front-end review This pull request needs a review from designer and removed 🚧 In progress do not merge Pull Request in progress, please do not merge labels Feb 4, 2024
fricoben
fricoben requested changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have claimed when I'm not connected or when I didn't do the quest.

Appart from that it seems to work fine !

Capture d’écran 2024-02-04 à 10 35 08

@fricoben fricoben added ❌ Change request Change requested from reviewer and removed 🔥 Ready for review This pull request needs a review 🦾 Needs front-end review This pull request needs a review from designer labels Feb 4, 2024
@Marchand-Nicolas Marchand-Nicolas added 🔥 Ready for review This pull request needs a review 🦾 Needs front-end review This pull request needs a review from designer and removed ❌ Change request Change requested from reviewer 🦾 Needs front-end review This pull request needs a review from designer labels Feb 4, 2024
fricoben
fricoben approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fricoben fricoben merged commit dd401d3 into testnet Feb 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricoben fricoben fricoben approved these changes

Assignees
No one assigned
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quests which are claimed “ Get reward “ option must be greyed out
2 participants
@Marchand-Nicolas @fricoben