Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add back button after opening chest #495

Merged
merged 4 commits into from
Feb 3, 2024

Conversation

Marchand-Nicolas
Copy link
Collaborator

close: #476

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goerli-starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 6:11pm
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 6:11pm

Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super !

One last thing. On the collect rewards button after launching the transaction can you add the confirmation modal we have everywhere. Once the modal is closed you can also router.back()

@fricoben fricoben added ❌ Change request Change requested from reviewer and removed 🔥 Ready for review This pull request needs a review 🦾 Needs front-end review This pull request needs a review from designer labels Jan 31, 2024
Copy link
Collaborator

@Kevils Kevils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make this button appear after the card animation?

@Kevils Kevils added ❌ Change request Change requested from reviewer and removed 🔥 Ready for review This pull request needs a review labels Feb 1, 2024
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick URL change and we're good

title="Your NFT is on it's way !"
closeModal={() => {
setModalTxOpen(false);
router.back();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I should have said it the first time but it makes more sense to make the user go to /quest-boost instead of .back() because back makes him go to the quest boost he just opened

) : null}
) : (
<div className="block ml-auto mr-auto">
<Button onClick={() => router.back()}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I should have said it the first time but it makes more sense to make the user go to /quest-boost instead of .back() because back makes him go to the quest boost he just opened

loop={false}
/>
<div className="mt-4">
<Button onClick={() => router.push("/")}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here we can make him go to the /quest-boost

@fricoben fricoben added ❌ Change request Change requested from reviewer and removed 🔥 Ready for review This pull request needs a review 🦾 Needs front-end review This pull request needs a review from designer labels Feb 2, 2024
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fricoben fricoben merged commit 499acbe into testnet Feb 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back button after rewards
3 participants