feat: add boosted check fix and click fix #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Marchand-Nicolas
requested changes
Jan 12, 2024
components/quests/quest.tsx
Outdated
Comment on lines
66
to
67
| fetchBoosts(id.toString()); | ||
| }, [isQuestBoosted]); |
There was a problem hiding this comment.
Shouldn't we add "id" as a dependency: }, [isQuestBoosted, id]); ? In case we want to dynamically change a card (this is not useful at the moment, but it would avoid weird behaviours in futur use cases I think), otherwise the "1000 USDC" tag would stay, even if it's not the same value as the former card or not boosted at all. What do you think?
There was a problem hiding this comment.
yes. this is a fair feedback. Adding props which are involved in the operation is a good practice. Thank you for pointing this out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes-