Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Description Quiz Style has been change #1106

Merged
merged 2 commits into from
Mar 2, 2025

Conversation

drakkomaximo
Copy link
Contributor

@drakkomaximo drakkomaximo commented Mar 1, 2025

Pull Request type

This pull request introduces a new StartScreen component for the quiz feature, which includes a button to start the quiz and displays the quiz name and description.

Please add the labels corresponding to the type of changes your PR introduces:

  • Feature

Resolves: #1046

Other information

This component is designed to enhance the user experience by providing a clear starting point for the quiz. It utilizes existing components like ScreenLayout, Button, and Typography to maintain consistency in the UI. The StartScreen component takes props for setting the quiz step, name, description, and current step, ensuring it is flexible and reusable.

Evidence:

image
image

Summary by CodeRabbit

  • Style
    • Updated the quiz start screen text styling to use a smaller body text type and a secondary color, enhancing visual clarity and distinction for a more polished user interface.
    • Introduced a new CSS variable for a semi-transparent white color to improve styling options.

Copy link

vercel bot commented Mar 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2025 11:39am

Copy link

vercel bot commented Mar 1, 2025

@drakkomaximo is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Mar 1, 2025

Walkthrough

The changes update the StartScreen component by modifying the rendering of the Typography component. The update changes the type prop to TEXT_TYPE.BODY_SMALL and adds a new color prop set to "secondary50". Additionally, a new CSS variable --secondary50 is defined in styles/globals.css. These modifications adjust the visual presentation of the text without affecting the underlying functionality or exported entities.

Changes

File(s) Change Summary
components/quiz/startScreen.tsx Updated the Typography component to change the type prop to TEXT_TYPE.BODY_SMALL and added a new color prop with the value "secondary50".
styles/globals.css Added a new CSS variable --secondary50: #ffffff80 in the :root selector.

Possibly related PRs

Suggested reviewers

  • Marchand-Nicolas

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @typescript-eslint/eslint-plugin@5.62.0
npm error Found: eslint@9.21.0
npm error node_modules/eslint
npm error dev eslint@"^9.11.1" from the root project
npm error peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/eslint-utils@4.4.1
npm error node_modules/@eslint-community/eslint-utils
npm error @eslint-community/eslint-utils@"^4.2.0" from @typescript-eslint/utils@5.62.0
npm error node_modules/@typescript-eslint/utils
npm error @typescript-eslint/utils@"5.62.0" from @typescript-eslint/eslint-plugin@5.62.0
npm error node_modules/@typescript-eslint/eslint-plugin
npm error dev @typescript-eslint/eslint-plugin@"^5.47.0" from the root project
npm error 1 more (eslint-config-next)
npm error 1 more (@typescript-eslint/type-utils)
npm error @eslint-community/eslint-utils@"^4.2.0" from eslint@9.21.0
npm error 5 more (@typescript-eslint/type-utils, ...)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0" from @typescript-eslint/eslint-plugin@5.62.0
npm error node_modules/@typescript-eslint/eslint-plugin
npm error dev @typescript-eslint/eslint-plugin@"^5.47.0" from the root project
npm error @typescript-eslint/eslint-plugin@"^5.4.2 || ^6.0.0 || ^7.0.0 || ^8.0.0" from eslint-config-next@14.2.24
npm error node_modules/eslint-config-next
npm error dev eslint-config-next@"^14.0.1" from the root project
npm error
npm error Conflicting peer dependency: eslint@8.57.1
npm error node_modules/eslint
npm error peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0" from @typescript-eslint/eslint-plugin@5.62.0
npm error node_modules/@typescript-eslint/eslint-plugin
npm error dev @typescript-eslint/eslint-plugin@"^5.47.0" from the root project
npm error @typescript-eslint/eslint-plugin@"^5.4.2 || ^6.0.0 || ^7.0.0 || ^8.0.0" from eslint-config-next@14.2.24
npm error node_modules/eslint-config-next
npm error dev eslint-config-next@"^14.0.1" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /.npm/_logs/2025-03-02T11_39_00_650Z-eresolve-report.txt
npm error A complete log of this run can be found in: /.npm/_logs/2025-03-02T11_39_00_650Z-debug-0.log


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a0f77c0 and ff97884.

📒 Files selected for processing (2)
  • components/quiz/startScreen.tsx (1 hunks)
  • styles/globals.css (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • components/quiz/startScreen.tsx
🔇 Additional comments (1)
styles/globals.css (1)

25-25: New CSS Variable for Semi-Transparent Secondary Color

The newly added CSS variable --secondary50 is defined with the value #ffffff80, providing a semi-transparent white that aligns well with the Figma design specifications for the quiz StartScreen component. Ensure that this variable is consistently used in components that rely on the secondary color palette for visual consistency.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@drakkomaximo drakkomaximo changed the title Style has been change feat: Description Quiz Style has been change Mar 1, 2025
Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The text should be a bit gray or transparent like that

@Marchand-Nicolas
Copy link
Collaborator

image Here is what I see

@drakkomaximo
Copy link
Contributor Author

image

That change should be there, but if you look at the Figma design, it’s not reflected. Only the image is visible. As I mentioned in the group, I follow the Figma design because it provides the exact sizes and colors I need, while the other one is just an image that gives me only a rough visual approximation.

The size was checked, and it was slightly smaller than what is in Figma. That's why I provided the evidence. Additionally, the exact color from Figma was applied. I’ll wait for instructions on whether to proceed or leave the PR as it is.

@drakkomaximo
Copy link
Contributor Author

image

Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great lgtm!

@Marchand-Nicolas Marchand-Nicolas merged commit 7153d3c into lfglabs-dev:testnet Mar 2, 2025
3 of 4 checks passed
@drakkomaximo drakkomaximo deleted the fix-1046 branch March 2, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refont quiz - Main page - Refont description text
2 participants