-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Description Quiz Style has been change #1106
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@drakkomaximo is attempting to deploy a commit to the LFG Labs Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes update the Changes
Possibly related PRs
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
npm warn config production Use 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That change should be there, but if you look at the Figma design, it’s not reflected. Only the image is visible. As I mentioned in the group, I follow the Figma design because it provides the exact sizes and colors I need, while the other one is just an image that gives me only a rough visual approximation. The size was checked, and it was slightly smaller than what is in Figma. That's why I provided the evidence. Additionally, the exact color from Figma was applied. I’ll wait for instructions on whether to proceed or leave the PR as it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great lgtm!
Pull Request type
This pull request introduces a new StartScreen component for the quiz feature, which includes a button to start the quiz and displays the quiz name and description.
Please add the labels corresponding to the type of changes your PR introduces:
Resolves: #1046
Other information
This component is designed to enhance the user experience by providing a clear starting point for the quiz. It utilizes existing components like ScreenLayout, Button, and Typography to maintain consistency in the UI. The StartScreen component takes props for setting the quiz step, name, description, and current step, ensuring it is flexible and reusable.
Evidence:
Summary by CodeRabbit