Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust runtime version. #2468

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Update rust runtime version. #2468

merged 3 commits into from
Feb 6, 2025

Conversation

Jakio815
Copy link
Collaborator

@Jakio815 Jakio815 commented Feb 2, 2025

Update rust runtime version.

@Jakio815 Jakio815 requested a review from erlingrj February 2, 2025 01:37
@Jakio815 Jakio815 added the rust Related to the Rust target label Feb 2, 2025
Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit hash in runtime-version.properties must match the commit hash of the reactor-rs submodule!

@Jakio815
Copy link
Collaborator Author

Jakio815 commented Feb 3, 2025

@erlingrj Thanks for checking. Why don't we also merge lf-lang/reactor-rs#50?

@erlingrj
Copy link
Collaborator

erlingrj commented Feb 4, 2025

It was now just merged. Could you update the submodule pointer and then run ./gradlew updateRustRuntime?

@Jakio815 Jakio815 requested a review from erlingrj February 4, 2025 16:29
Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@erlingrj erlingrj added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@erlingrj erlingrj added this pull request to the merge queue Feb 6, 2025
Merged via the queue into master with commit c77ea97 Feb 6, 2025
23 checks passed
@erlingrj erlingrj deleted the rs-runtime-version branch February 6, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Related to the Rust target upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants