Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recenter-top-bottom (emacs-mode) #1767

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Conversation

Prikaz98
Copy link
Contributor

@Prikaz98 Prikaz98 commented Feb 8, 2025

Emacs default behavior of (C-l recenter-top-bottom)

lem-recenter-top-bottom

Emacs default behavior of (C-l recenter-top-bottom)
@Prikaz98 Prikaz98 changed the title recenter-top-bottom recenter-top-bottom (emacs-mode) Feb 8, 2025
@cxxxr
Copy link
Member

cxxxr commented Feb 10, 2025

Thank you for the PR.
BTW since lem is not emacs, I don't think it's necessary to match the emacs default.
Is it possible to add just the command and change it in the config?

For example, I would like to have options to change the behavior of recenter in the future (such as the behavior of JetBrains C-l).

@Prikaz98
Copy link
Contributor Author

Prikaz98 commented Feb 10, 2025

Is it possible to add just the command and change it in the config?

Yes, I don't mind. I believe it will be better to return default binding (C-l 'recenter) because changing behavior can affect some user who already got used to 'recenter and 'recenter-top-bottom will be just an option to configure, for users like me who like this feature.

Copy link
Member

@cxxxr cxxxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!
I made one comment, but I think it's good.

@cxxxr cxxxr merged commit 791397f into lem-project:main Feb 10, 2025
2 checks passed
CarsonEllsworth33 pushed a commit to CarsonEllsworth33/lem that referenced this pull request Feb 28, 2025
* recenter-top-bottom

Emacs default behavior of (C-l recenter-top-bottom)

* fix: window-recenter-top-bottom should return smt

* return prev keymap

* removed unused variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants