Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change timing of calling didDismiss #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ykrods
Copy link

@ykrods ykrods commented Mar 26, 2020

I think it's better to call didDismiss delegate function after the dismissing animation has finished.

This makes it easy to make another screen transition or get presentedController in the callback.

@ykrods ykrods force-pushed the master branch 2 times, most recently from 5654c03 to 12050a9 Compare March 26, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant