Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nan issues in fftconvolve #114

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ggmarshall
Copy link
Contributor

@ggmarshall ggmarshall commented Feb 20, 2025

Closes #113

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.17%. Comparing base (905e1a8) to head (04a089d).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   60.39%   60.17%   -0.23%     
==========================================
  Files          51       52       +1     
  Lines        3469     3500      +31     
==========================================
+ Hits         2095     2106      +11     
- Misses       1374     1394      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fft convolve gives all nan values for last entry in table iteration i.e. when buffer not filled
1 participant