Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fft convolve gives all nan values for last entry in table iteration i.e. when buffer not filled #113

Open
ggmarshall opened this issue Feb 17, 2025 · 5 comments · May be fixed by #114
Open
Labels
bug Something isn't working

Comments

@ggmarshall
Copy link
Contributor

No description provided.

@ggmarshall ggmarshall changed the title fft convolve gives all nan values for last entry in iterator i.e. when buffer not filled fft convolve gives all nan values for last entry in table iteration i.e. when buffer not filled Feb 17, 2025
@iguinn
Copy link
Collaborator

iguinn commented Feb 18, 2025

To make sure I'm understanding this, the issue here is that it's not vectorizing correctly, so that the outputs for the different entries are not independent? And this shows up if you have NaNs, causing the NaNs to propagate everywhere? And this is true even with the axis argument?

@iguinn iguinn added the bug Something isn't working label Feb 18, 2025
@ggmarshall
Copy link
Contributor Author

ggmarshall commented Feb 18, 2025

Yes it would seem so, which axis argument sorry?

@iguinn
Copy link
Collaborator

iguinn commented Feb 18, 2025

@ggmarshall
Copy link
Contributor Author

ah yes sorry I though you meant something in dspeed, I'll see if this fixes, I'm going to take the processor apart tomorrow to see where the problem is

@ggmarshall
Copy link
Contributor Author

ok so if any nans are in input it will give nan output even with axis specified

@ggmarshall ggmarshall linked a pull request Feb 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants