-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add licensing guidelines to ReadtheDocs #21
Conversation
source_suffix = { | ||
'.rst': 'restructuredtext', | ||
'.md': 'markdown', | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was super happy to see how easy it was to enable both restructuredtext and markdown! Yay sphinx
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! This is awesome
|
||
|
||
|
||
# -- Options for HTML output ------------------------------------------------- | ||
# https://www.sphinx-doc.org/en/master/usage/configuration.html#options-for-html-output | ||
|
||
html_theme = 'alabaster' | ||
html_theme = 'sphinx_rtd_theme' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going with this for now, but definitely open to ideas for other themes we might want to use.
and shows the different categories of licenses available and the types of licenses that support their respective | ||
requirements. | ||
|
||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was having lots of trouble trying to get HTML to render in sphinx
/ReadtheDocs, so I decided to just show a static image of the table instead 🤷🏻 . Maybe we can get embedded HTML working in a future PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the table caption is above the table again. We might want to re-make that png and add the caption in the .md file below the image at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for doing this
Just noticed that the Read the Docs build failed. Looks like an issue with the module 'myst_parser' |
I think I solved the RTD build issues. These updates are now 'live' here: https://lasp-developer-guide--21.org.readthedocs.build/en/21/licensing.html |
This PR moves the licensing guideline to under the
sphinx
source tree, thus allowing it to render in ReadTheDocs. I also made a few style changes to the licensing markdown file, and enabled support for markdown in the sphinx config.