Skip to content

Commit

Permalink
update for 22 December 2022 release. Remove obsoleted USER-VCSGC pack…
Browse files Browse the repository at this point in the history
…age.
  • Loading branch information
akohlmey committed Dec 22, 2022
1 parent c786bc3 commit a32d747
Show file tree
Hide file tree
Showing 9 changed files with 5 additions and 2,474 deletions.
3 changes: 1 addition & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ include(LAMMPSInterfacePlugin)
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR})

if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
add_custom_target(package DEPENDS package-USER-AEAM package-USER-REBOMOS package-USER-VCSGC)
add_custom_target(package DEPENDS package-USER-AEAM package-USER-REBOMOS)
endif()
add_subdirectory(USER-AEAM)
add_subdirectory(USER-REBOMOS)
add_subdirectory(USER-VCSGC)
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ for a number of reasons, but ported to be compatible with the
|--------------|----------------------------------------------------|
| USER-AEAM | https://github.com/psaidi/AEAM |
| USER-REBOMOS | https://matsci.org/t/pair-rebomos/30503 |
| USER-VCSGC | https://gitlab.com/materials-modeling/vcsgc-lammps |

As of the 22 December 2022 LAMMPS release, the USER-VCSGC package
code has been merged with upstream and the corresponding fix is now
available in the MC package. The plugin package has thus been removed.

To compile and configure all plugins

Expand Down
73 changes: 0 additions & 73 deletions USER-VCSGC/CMakeLists.txt

This file was deleted.

11 changes: 0 additions & 11 deletions USER-VCSGC/README.md

This file was deleted.

8 changes: 0 additions & 8 deletions USER-VCSGC/README.txt

This file was deleted.

Loading

3 comments on commit a32d747

@jan-janssen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akohlmey Is there a specific reason why the VCSGC package was removed? While the code might be a bit old, it is actively used for multiple scientific projects, so I would be very happy to have it included in the lammps-plugins even though I am not the developer of this package.

@akohlmey
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akohlmey Is there a specific reason why the VCSGC package was removed? While the code might be a bit old, it is actively used for multiple scientific projects, so I would be very happy to have it included in the lammps-plugins even though I am not the developer of this package.

It was removed because @athomps and I removed most of the cruft from the source code and the fix is now a full member of the MC package of the main LAMMPS distribution: https://docs.lammps.org/fix_sgcmc.html
Thus there is no more need for the plugin here.

@jan-janssen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great - thanks a lot for explanation.

Please sign in to comment.