-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-852] Configurator: Migrate effects config #856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
tvillegas98
previously approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tvillegas98
previously approved these changes
Sep 2, 2024
tvillegas98
previously approved these changes
Sep 5, 2024
AminArria
requested changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure where/how, but the Valtimer dash is broken
Stacktrace
[error] GenServer #PID<0.1554.0> terminating
** (KeyError) key :execute_multiple_times not found in: {:damage_immunity, %{effect_delay_ms: 0, execute_multiple_times: false}}
If you are using the dot syntax, such as map.field, make sure the left-hand side of the dot is a map
(arena 0.7.1) lib/arena/game/effect.ex:158: anonymous fn/5 in Arena.Game.Effect.apply_effect_mechanic/3
(stdlib 5.0.2) maps.erl:416: :maps.fold_1/4
(elixir 1.16.1) lib/enum.ex:2528: Enum."-reduce/3-lists^foldl/2-0-"/3
(arena 0.7.1) lib/arena/game/effect.ex:143: anonymous fn/2 in Arena.Game.Effect.apply_effect_mechanic_to_entities/1
(stdlib 5.0.2) maps.erl:416: :maps.fold_1/4
(arena 0.7.1) lib/arena/game_updater.ex:259: Arena.GameUpdater.handle_info/2
(stdlib 5.0.2) gen_server.erl:1077: :gen_server.try_handle_info/3
(stdlib 5.0.2) gen_server.erl:1165: :gen_server.handle_msg/6
(stdlib 5.0.2) proc_lib.erl:241: :proc_lib.init_p_do_apply/3
tvillegas98
previously approved these changes
Sep 12, 2024
AminArria
previously approved these changes
Sep 12, 2024
7a17a7c
AminArria
approved these changes
Sep 12, 2024
tvillegas98
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Keep migrating fields from config.json to configurator app
Part of #852
Summary of changes
How to test it?
Start a match and everything should keep working as before
Checklist