[GH-1059] - Send match's map to the client #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvillegas98
changed the base branch from
main
to
link-game-modes-table-with-matchmaking
tvillegas98
changed the title
manucamejo
previously approved these changes
Feb 4, 2025
manucamejo
previously approved these changes
Feb 5, 2025
Base automatically changed from
link-game-modes-table-with-matchmaking
to
main
February 5, 2025 22:30
Nico-Sanchez
dismissed
manucamejo’s stale review
The base branch was changed.
tvillegas98
force-pushed
the
gh-1059-send-the-map-to-the-client
branch
2 times, most recently
from
886e244 to
7e8d46a
Compare
- spikes were not working - random position in map needs to be within a circle
* feat: add team size to game mode configurations * feat: changes on the game mode configurations table and views - renamed name to type - add team size parameter when the game mode is teams - add team type to game modes * feat: create an endpoint to retrieve the game mode configuration * chore: move every migration into one file * chore: add seeds for game modes * feat: add new fields and logic for game mode form * chore: remove the amount of params from the map mode params this is done because in the matchmaking we must always specify the amount of players to create a match * feat: use the game modes in the matchmaking * code: handle the failed requests when the application starts * chore: remove not used require * feat: restore the has many in the game mode configurations * feat: fix pair and battle not using the game mode configuration * fix: correctly parse the map mode params * feat: changes on the initial positions and map - select the initial positions based on if its teams or solo - select a random map amongst all the availables in a game mode * chore: format * chore: credo * chore: fix seeds * chore: mix format again * feat: use the team size parameter * chore: remove not used field in migration * fix: deathmatch and battle were not working * feat: restore the amount of players to the map mode params * feat: use the map amount params in the matchmakings * chore: add quickgame to seeds * feat: use the map selected from the matchmaking * chore: restore changes in game modes form * chore: fix typo in game mode's form * chore: remove not needed map configurations from seeds * refactor: merge team and solo positions into one * feat: remove the name and filter and get the game mode configuration by team size and type * chore: send the update params event in the init of each matchmaking * refactor: modularize function in matchmaking module * code: rename variable * fix: errors - templates not working due to an unexistent field - battle mode not working * feat: only display active maps for map mode params * chore: mix format * feat: filter maps only in the game mode form --------- Co-authored-by: Nicolas Sanchez <sanchez.nicolas96@gmail.com>
tvillegas98
force-pushed
the
gh-1059-send-the-map-to-the-client
branch
from
81943cf to
c0ce625
Compare
manucamejo
approved these changes
Feb 6, 2025
Nico-Sanchez
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This PR should be merged alongside https://github.com/lambdaclass/champions_of_mirra/pull/2457
Motivation
Closes #1059
Summary of changes
DISCLAIMER: This PR increases arena version
How to test it?
Playtested it with the PR mentioned above and try to find Araban while playing deathmatch!
Checklist