Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show effects properly in configurator #1035

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

Nico-Sanchez
Copy link
Collaborator

@Nico-Sanchez Nico-Sanchez commented Jan 8, 2025

Motivation

Closes #1036

Summary of changes

How to test it?

Test forms in localhost:4100

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

Base automatically changed from gh-1027-add-game-mode-params to main January 9, 2025 17:58
@Nico-Sanchez Nico-Sanchez force-pushed the show-effects-properly-in-configurator branch from aa4bb65 to 05dea3b Compare January 9, 2025 18:01
@Nico-Sanchez Nico-Sanchez marked this pull request as ready for review January 9, 2025 18:01
Copy link
Contributor

@tvillegas98 tvillegas98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this!

Although I'm getting an error not related to this PR, is it known issue? It happens when trying to edit and save an skill

Screenshot 2025-01-09 at 4 03 18 pm

@Nico-Sanchez
Copy link
Collaborator Author

Great work on this!

Although I'm getting an error not related to this PR, is it known issue? It happens when trying to edit and save an skill

Screenshot 2025-01-09 at 4 03 18 pm

Yeah. it's a known issue. For now I'm just adding an empty list as vertices []

@manucamejo manucamejo merged commit 66967d3 into main Jan 9, 2025
1 check passed
@manucamejo manucamejo deleted the show-effects-properly-in-configurator branch January 9, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename skill and mechanic effect associations to avoid misunderstandings and show them in the Configurator UI.
3 participants