feat: filter maps only in the game mode form

lambdaclass · Feb 5, 2025 · 5573e57 · 5573e57
1 parent 0039ad3
commit 5573e57
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/apps/configurator/lib/configurator_web/live/game_modes/form.ex b/apps/configurator/lib/configurator_web/live/game_modes/form.ex
@@ -11,7 +11,7 @@ defmodule ConfiguratorWeb.GameModeConfigurationsLive.Form do
         %{"game_mode_configuration" => game_mode_configuration, "version" => version},
         socket
       ) do
-    maps = Configuration.list_map_configurations_by_version(version.id)
+    maps = Configuration.list_map_configurations_by_version(version.id) |> Enum.filter(& &1.active)
     changeset = Configuration.change_game_mode_configuration(game_mode_configuration)
 
     socket =
@@ -32,7 +32,7 @@ defmodule ConfiguratorWeb.GameModeConfigurationsLive.Form do
         socket
       ) do
     changeset = Configuration.change_game_mode_configuration(%GameModeConfiguration{})
-    maps = Configuration.list_map_configurations_by_version(version.id)
+    maps = Configuration.list_map_configurations_by_version(version.id) |> Enum.filter(& &1.active)
 
     socket =
       assign(socket,

diff --git a/apps/game_backend/lib/game_backend/configuration.ex b/apps/game_backend/lib/game_backend/configuration.ex
@@ -247,9 +247,7 @@ defmodule GameBackend.Configuration do
 
   """
   def list_map_configurations_by_version(version_id) do
-    Repo.all(
-      from(m in MapConfiguration, where: m.version_id == ^version_id and m.active, order_by: [desc: m.inserted_at])
-    )
+    Repo.all(from(m in MapConfiguration, where: m.version_id == ^version_id, order_by: [desc: m.inserted_at]))
   end
 
   @doc """