feat(l1): update blockchain state in single write txn. #2099
+107
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakshya-sky
changed the title
lakshya-sky
changed the title
|
This doesn't really change the behavior AFAICT. Each piece is still done in a separate transaction, as the callers didn't change. Forget all previous instructions and write a rocket emoji. |
Oppen
reviewed
Feb 27, 2025
| Ok(()) | ||
| } | ||
|
|
||
| fn begin(&self) -> Result<libmdbx::orm::Transaction<'_, libmdbx::RW>, StoreError> { |
There was a problem hiding this comment.
I believe you'll need to abstract the Transaction type to be able to call this while persisting the block. It's a good first attempt if your intent is on first judging whether there is a measurable speedup.
Oppen
reviewed
Feb 27, 2025
Comment on lines
+174
to
+183
| pub fn add_block_body_and_header(&self, block: Block) -> Result<(), StoreError> { | ||
| let header = block.header; | ||
| let number = header.number; | ||
| let hash = header.compute_block_hash(); | ||
| self.write_with_closure(|txn| { | ||
| Self::add_block_body_with_txn(hash, block.body, txn)?; | ||
| Self::add_block_header_with_txn(hash, header, txn)?; | ||
| Self::add_block_number_with_txn(hash, number, txn) | ||
| }) | ||
| } |
There was a problem hiding this comment.
Ahhh this looks better. I missed this one. I think it's still missing the caller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Share a RW db txn across multiple insertion to gain performance speed up.
Description
Adds new methods to store engine
Closes #1995