Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(l1): update calc_excess_blob_gas #2094

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

avilagaston9
Copy link
Contributor

@avilagaston9 avilagaston9 commented Feb 26, 2025

Motivation

We missed updating calc_excess_blob_gas in crates/common/types/block.rs. The old version was using a hardcoded u64, triggering validation errors when syncing in pectra-devnet-6.

Description

  • Moves the implementation of calc_excess_blob_gas from crates/blockchain/payload.rs to crates/common/types/block.rs and removes the old one.

Closes None

Copy link

| File                                                         | Lines | Diff |
+--------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/blockchain/payload.rs | 556   | -13  |
+--------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/common/types/block.rs | 706   | +21  |
+--------------------------------------------------------------+-------+------+

Total lines added: +21
Total lines removed: 13
Total lines changed: 34

@avilagaston9 avilagaston9 self-assigned this Feb 26, 2025
@avilagaston9 avilagaston9 marked this pull request as ready for review February 26, 2025 21:38
@avilagaston9 avilagaston9 requested a review from a team as a code owner February 26, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants