-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(l1): move mempool from Store to Blockchain #2089
Merged
Merged
Changes from 6 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
878d920
add hex-literal to blockchain only for a test could be removed
LeanSerra 7b5fbc8
move mempool functions from Store to new struct Mempool
LeanSerra c4fa7db
Merge branch 'main' into l1/move_mempool_from_store
LeanSerra 08a4a49
fix missing argument for l2
LeanSerra c05fc05
remove arc from mempool
LeanSerra 52271d6
pass blockchain as argument when using both store and mempool
LeanSerra 906f68d
move basic mempool operations to blockchain struct, remove duplicate …
LeanSerra 3df7183
Merge branch 'main' into l1/move_mempool_from_store
LeanSerra 065e90f
remove hex-literal dependecy, change test to use hex::decode
LeanSerra 99f43c4
move filter transaction functions to mempool struct
LeanSerra f02ad2d
add comment indicating that blockchain add_tx functions perform valid…
LeanSerra e375c39
move get_nonce function to mempool
LeanSerra d240452
fix using wrong filter function when broadcasting NewPooledTransactio…
LeanSerra 35db6fe
pass both blockchain and store when needed for l2 stuff
LeanSerra fea985e
pass both blockchain and store when needed for connection.rs
LeanSerra 8e61405
pass both blockchain and store when needed
LeanSerra 43d02f1
add missing parameter for ethrex_p2p::start_network in dev mode
LeanSerra 539af5c
change .blockchain.storage to .storage
LeanSerra 7377508
change .blockchain.storage to .storage
LeanSerra 308fab7
change .blockchain.storage to .storage
LeanSerra c3e7bdf
change .blockchain.storage to .storage
LeanSerra 482e796
Merge branch 'main' into l1/move_mempool_from_store
LeanSerra f6c0715
pass blockchain as argument instead of mempool
LeanSerra 36fa3aa
fix function call arguments
LeanSerra 6fd0f21
Merge branch 'main' into l1/move_mempool_from_store
LeanSerra a19887a
change blockchain.storage to storage for tests
LeanSerra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we pass a blockchain reference instead of cloning? I would disable
clone
for a blockchain, since it's a singleton.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would mean adding an Arc and then cloning that Arc right? What we are doing right now is technically the same as the only field we are really cloning is the EVM both the store and mempool are internally arcs so when we clone them we are only cloning the references. I will still change it to Arc if thats what makes more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, leave it as is then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be tackled in a separate PR, moving
blockchain
to an Arc