fix(l1): full-sync with both consensus and execution node #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mpaulucci
reviewed
Feb 26, 2025
crates/networking/p2p/sync.rs
Outdated
| @@ -265,7 +265,7 @@ impl SyncManager { | |||
| store.add_block_headers(block_hashes.clone(), block_headers)?; | |||
|
|
|||
| if self.sync_mode == SyncMode::Full { | |||
| self.download_and_run_blocks(&mut block_hashes, store.clone()) | |||
| self.download_and_run_blocks(&mut block_hashes, store.clone(), sync_head) | |||
There was a problem hiding this comment.
maybe, instead of passing sync_head , you should filter block_hashes so that every block after sync_head is filtered out. Does this make sense?
There was a problem hiding this comment.
Yes! Actually, my approach for some reason wasn't working. This is simpler and it is working in the server. I will update the PR later
crates/networking/p2p/sync.rs
Outdated
Comment on lines
268
to
275
| if sync_head_found { | ||
| // Filter out everything after the sync_head | ||
| block_hashes = block_hashes | ||
| .iter() | ||
| .take_while(|&hash| *hash != sync_head) | ||
| .cloned() | ||
| .collect(); | ||
| } |
There was a problem hiding this comment.
This logic should be on both sync modes: snap and full.
There was a problem hiding this comment.
Updated in 973719d!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, during full-sync, we download, execute and store blocks as canonical in chunks of
MAX_BLOCK_BODIES_TO_REQUEST=128. However, we do not verify whether we are ahead of the consensus head, which results in invalidforkChoiceresponses.Description
Closes #2066