-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(l1): remove total_difficulty
#2052
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this until we're sure it doesn't bring any regressions.
In mainnet this could be an issue since we have to deal with pre merge blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching the approach on this. Let's merge it, and if we find an issue, we can revert it.
Description
This PR fully removes
total_difficulty
field, as already done on #307, but later reverted on #566.While doing so, it also removes the
total_difficulty_check
function, so it solves #790Closes #790