-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(l2): erc20 load test #2048
base: main
Are you sure you want to change the base?
Conversation
|
36d4ffe
to
467d773
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure, where does this binary come from? Is it code you wrote, compiled? Otherwise, what's its license?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This binary is the artifact resulting from the compilation of the ERC20.sol + deps.sol files (you can double check it using the solc compiler).
The used libraries are all MIT and properly accounted for: check the deps.sol file and you'll see.
Plus, I left a comment in test.rs linking to the tutorial I've used to generate each of these files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh I'm guessing yes.
Let's move the solidity source code and its compiled binary to the |
Also let's add a makefile target like in #2090 that runs this new load test on "default" settings so it's easy to do a quick run |
1cd7d99
to
9a6ef8f
Compare
Motivation
We were missing an I/O intensive benchmark, our first guess is that an ERC20
transfering benchmark should suffice for this.
Description
Closes #1999.