Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(l2): erc20 load test #2048

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

feat(l2): erc20 load test #2048

wants to merge 22 commits into from

Conversation

fkrause98
Copy link
Contributor

@fkrause98 fkrause98 commented Feb 21, 2025

Motivation

We were missing an I/O intensive benchmark, our first guess is that an ERC20
transfering benchmark should suffice for this.

Description

  • Add new erc20 command for the ethrex_l2 test command.

Closes #1999.

Copy link

github-actions bot commented Feb 21, 2025

| File                                                               | Lines | Diff |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ethrex_l2/src/commands/test.rs | 410   | +200 |
+--------------------------------------------------------------------+-------+------+

Total lines added: +200
Total lines removed: 0
Total lines changed: 200

@fkrause98 fkrause98 changed the title feat: working erc20 deploy feat: erc20 load tet Feb 21, 2025
@fkrause98 fkrause98 changed the title feat: erc20 load tet feat: erc20 load test Feb 21, 2025
@fkrause98 fkrause98 changed the title feat: erc20 load test feat(cmd): erc20 load test Feb 21, 2025
@fkrause98 fkrause98 marked this pull request as ready for review February 24, 2025 18:56
@fkrause98 fkrause98 requested a review from a team as a code owner February 24, 2025 18:56
@fkrause98 fkrause98 changed the title feat(cmd): erc20 load test feat(l2): erc20 load test Feb 24, 2025
@fkrause98 fkrause98 marked this pull request as draft February 24, 2025 20:28
@fkrause98 fkrause98 marked this pull request as ready for review February 25, 2025 21:25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, where does this binary come from? Is it code you wrote, compiled? Otherwise, what's its license?

Copy link
Contributor Author

@fkrause98 fkrause98 Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This binary is the artifact resulting from the compilation of the ERC20.sol + deps.sol files (you can double check it using the solc compiler).

The used libraries are all MIT and properly accounted for: check the deps.sol file and you'll see.
Plus, I left a comment in test.rs linking to the tutorial I've used to generate each of these files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I'm guessing yes.

@jrchatruc
Copy link
Collaborator

Let's move the solidity source code and its compiled binary to the test_data folder like I did on #2090; given the load tests are not just for L2 it's probably better to just have them on that directory

@jrchatruc
Copy link
Collaborator

jrchatruc commented Feb 25, 2025

Also let's add a makefile target like in #2090 that runs this new load test on "default" settings so it's easy to do a quick run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf: add IO heavy contracts to load test
3 participants