Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(l1): hive engine-cancun suite ForkId tests #1976

Merged
merged 6 commits into from
Feb 19, 2025
Merged

fix(l1): hive engine-cancun suite ForkId tests #1976

merged 6 commits into from
Feb 19, 2025

Conversation

MarcosNicolau
Copy link
Contributor

Motivation
Fix failing tests in the engine-cancun hive suite.

Description
This update fixes all tests matching the pattern ForkId: * in the engine-cancun suite. The issue resulted from not filtering out duplicate fork values and failing to exclude forks that occurred before the genesis block.

Advances on #1285

@MarcosNicolau MarcosNicolau requested a review from a team as a code owner February 17, 2025 19:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading 

| File                                                                      | Lines | Diff |
+---------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/common/types/fork_id.rs            | 422   | +9   |
+---------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/common/types/genesis.rs            | 623   | +6   |
+---------------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/p2p/rlpx/eth/backend.rs | 118   | +6   |
+---------------------------------------------------------------------------+-------+------+

Total lines added: +21
Total lines removed: 0
Total lines changed: 21

mpaulucci
mpaulucci approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@mpaulucci mpaulucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcosNicolau MarcosNicolau added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 6bd2f76 Feb 19, 2025
23 checks passed
@MarcosNicolau MarcosNicolau deleted the fix/hive-engine-fork-id branch February 19, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JereSalo JereSalo JereSalo left review comments

@mpaulucci mpaulucci mpaulucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcosNicolau @mpaulucci @JereSalo