add pprof support #693
Merged
add pprof support #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort the cli options when the `--help` command is used Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Bool flags seems to have been broken by a clap upgrade, meaning they required an argument to be provided in order to work. Moreover, this PR removes the `--enable-verification` flag, which was no longer used by the code. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Allow CPU profiling using pprof. There's a new boolean flag `--enable-pprof` that exposes a new HTTP endpoint named `/debug/pprof/cpu`. By doing a GET request against the endpoint, a pprof profile is generated and downloaded. The endpoint takes two optional query parameters: - interval: the length in seconds of the profile (30 secs by default) - frequency: profiling frequency (99 Hz by default) Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Avoid regressions when handling boolean flags Signed-off-by: Flavio Castelli <fcastelli@suse.com>
fabriziosestito
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow CPU profiling using pprof. There's a new boolean flag
--enable-pprofthat exposes a new HTTP endpoint named/debug/pprof/cpu.By doing a GET request against the endpoint, a pprof profile is generated and downloaded.
The endpoint takes two optional query parameters:
While working on this feature, I found some issues related with cli flags: