Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump tracing-opentelemetry from 0.22.0 to 0.23.0 #691

Merged
merged 4 commits into from
Mar 21, 2024
Merged

build(deps): bump tracing-opentelemetry from 0.22.0 to 0.23.0 #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73dade3
build(deps): bump tracing-opentelemetry from 0.22.0 to 0.23.0
dependabot[bot] Mar 7, 2024
8456814
build(deps): bump opentelemetry dependencies
fabriziosestito Mar 15, 2024
fcb817a
fix(metrics): rename MeterProvider in SdkMeterProvider
fabriziosestito Mar 15, 2024
4f17c71
docs: fix DEVELOPMENT.md boolean flags
fabriziosestito Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 25 additions & 53 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ k8s-openapi = { version = "0.21.1", default-features = false, features = [
lazy_static = "1.4.0"
mime = "0.3"
num_cpus = "1.16.0"
opentelemetry-otlp = { version = "0.14.0", features = ["metrics", "tonic"] }
opentelemetry = { version = "0.21", default-features = false, features = [
opentelemetry-otlp = { version = "0.15.0", features = ["metrics", "tonic"] }
opentelemetry = { version = "0.22.0", default-features = false, features = [
"metrics",
"trace",
] }
opentelemetry_sdk = { version = "0.21", features = ["rt-tokio"] }
opentelemetry_sdk = { version = "0.22.1", features = ["rt-tokio"] }
procfs = "0.16"
pprof = { version = "0.13", features = ["prost-codec"] }
policy-evaluator = { git = "https://github.com/kubewarden/policy-evaluator", tag = "v0.16.2" }
Expand All @@ -42,7 +42,7 @@ thiserror = "1.0"
tokio = { version = "^1.36.0", features = ["full"] }
tracing = "0.1"
tracing-futures = "0.2"
tracing-opentelemetry = "0.22.0"
tracing-opentelemetry = "0.23.0"
tracing-subscriber = { version = "0.3", features = ["ansi", "fmt", "json"] }
semver = { version = "1.0.22", features = ["serde"] }
mockall_double = "0.3"
Expand Down
4 changes: 2 additions & 2 deletions DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ cargo run --release -- \
--workers 2 \
--log-fmt otlp \
--log-level debug \
--enable-metrics true \
--ignore-kubernetes-connection-failure true
--enable-metrics \
--ignore-kubernetes-connection-failure
```

Some notes about this command:
Expand Down
4 changes: 2 additions & 2 deletions src/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use opentelemetry::{metrics, KeyValue};
use opentelemetry_otlp::{ExportConfig, WithExportConfig};
use opentelemetry_sdk::metrics::MeterProvider;
use opentelemetry_sdk::metrics::SdkMeterProvider;
use opentelemetry_sdk::runtime;

mod policy_evaluations_total;
Expand All @@ -10,7 +10,7 @@

const METER_NAME: &str = "kubewarden";

pub fn setup_metrics() -> metrics::Result<MeterProvider> {
pub fn setup_metrics() -> metrics::Result<SdkMeterProvider> {

Check warning on line 13 in src/metrics.rs

View check run for this annotation

Codecov / codecov/patch

src/metrics.rs#L13 

Added line #L13 was not covered by tests
opentelemetry_otlp::new_pipeline()
.metrics(runtime::Tokio)
.with_exporter(
Expand Down
Loading