feat: Expand grafana dashboard, bump to schemaVersion 38 #602
+2,327
−586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump dashboard to schemaVersion 38, from Grafana vesion 10.2.0. - Add a "General overview" row. - Filter the preexisting visualizations with `request_origin="validate"`. - Add new visualizations pertaining audit requests, filtering with `request_origin="audit"`. - Leave latency untouched. Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
viccuad
force-pushed
the
grafana-request-origin
branch
from
a05dd70 to
6baea7d
Compare
jvanz
approved these changes
Nov 27, 2023
|
This is the current version, with the requested changes. Tested it against a full deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #597
request_origin="validate".request_origin="audit".Test
Tested by deploying grafana with docker compose, and editing the dashboard via the UI. The UI has a linter and informs if the queries fail to parse or are invalid.
Still would be good to test it against an audit scanner + opentelemetry deployment.
Additional Information
Tradeoff
Potential improvement