ci: Add version-check job to check Cargo.toml on release #1102
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On release (when the CI workflow is triggered by a tag), check that the Cargo.toml `version` matches the tag. This prevents releasing badly tagged or version-annotated images. This is lifted from kwctl's CI. Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
fabriziosestito
approved these changes
Feb 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1102 +/- ##
==========================================
- Coverage 57.52% 57.02% -0.51%
==========================================
Files 18 18
Lines 1189 1189
==========================================
- Hits 684 678 -6
- Misses 505 511 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jvanz
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On release (when the CI workflow is triggered by a tag), check that the Cargo.toml
versionmatches the tag.This prevents releasing badly tagged or version-annotated images.
This is lifted from kwctl's CI.
Test
Tested locally.
Additional Information
Tradeoff
Potential improvement