-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nodepool): support timezone for disruption budgets #2032
base: main
Are you sure you want to change the base?
feat(nodepool): support timezone for disruption budgets #2032
Conversation
Signed-off-by: flavono123 <flavono123@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flavono123 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @flavono123. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
are we have to emit a new event for a wrong timezone?:
https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/cron-job-v1/#CronJobSpec |
Pull Request Test Coverage Report for Build 13538517552Details
💛 - Coveralls |
Fixes #1446, partially
Description
add the field
disruption.budgets[].timeZone
for NodePoolSpec.if not set, use UTC as default.
validate if not schedule is set, timeZone also cannot be.
referenced one in CronJobSpec and already tried PR #1447
How was this change tested?
make verify && go test ./pkg/apis/v1/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.