Skip to content

Commit

Permalink
fix references
Browse files Browse the repository at this point in the history
  • Loading branch information
rschalo committed Feb 27, 2025
1 parent cee45d7 commit 3878c94
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/controllers/nodeclaim/lifecycle/events.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func UnregisteredTaintMissingEvent(nodeClaim *v1.NodeClaim) events.Event {
return events.Event{
InvolvedObject: nodeClaim,
Type: corev1.EventTypeWarning,
Reason: events.UnregisteredTaintMissing,
Reason: "UnregisteredTaintMissing",
Message: fmt.Sprintf("Missing %s taint which prevents registration related race conditions on Karpenter-managed nodes", v1.UnregisteredTaintKey),
DedupeValues: []string{string(nodeClaim.UID)},
}
Expand Down
3 changes: 1 addition & 2 deletions pkg/controllers/nodeclaim/lifecycle/registration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

v1 "sigs.k8s.io/karpenter/pkg/apis/v1"
"sigs.k8s.io/karpenter/pkg/events"
"sigs.k8s.io/karpenter/pkg/test"
. "sigs.k8s.io/karpenter/pkg/test/expectations"
)
Expand Down Expand Up @@ -139,7 +138,7 @@ var _ = Describe("Registration", func() {
node = ExpectExists(ctx, env.Client, node)
Expect(node.Labels).To(HaveKeyWithValue(v1.NodeRegisteredLabelKey, "true"))

Expect(recorder.Calls(events.UnregisteredTaintMissing)).To(Equal(1))
Expect(recorder.Calls("UnregisteredTaintMissing")).To(Equal(1))
})

It("should sync the labels to the Node when the Node comes online", func() {
Expand Down

0 comments on commit 3878c94

Please sign in to comment.